Great that you started to patch this! Two comments though. In the first two changes you are doing the flipping yourself. Wouldn't it be easier to call the method fillHorizontalRect:withImage:flipped: with the last parameter set to YES? It would be even better if Camaelong moved that isFlipped parameter one method up, but this is a larger change.
The other thing is that I don't know why the clipping failed for you and would like to get more information on that. The Camaelon code there again wasn't optimal. If you want to clip to a rectangle,just use [NSBezierPath clipRect:]. I hope somebody picks up your changes and gets Camaelon fully compatible with current GUI. Thank you for starting this. Fred Andreas Schik wrote: > Hi there, > after the short discussion last week about the Camaelon themes not > being drawn correctly anymore, I sat down and tried to make something > up. > I did some quick hackery to fix the (at least for me) most obvious > problems: Table headers and sliders. You find my changes in te > attached patch which is against today's SVN. > Some remarks: > 1. I have left the original code outcommented. This was more or less > for documentary reasons. > 2. GraphicToolbox contains code to save and restore graphics contexts > in various places. For some reason on my system only the vertical > rectabgle drawing worked, the hrozontal did not. I was able to fill > horizontal rects only after disabling the context saving/restoring. I > have no idea why this is the case. I solved the clipping issue for the > time being by reordering the drawing of the parts, e.g. > left-fill-right. This may not work for some rare cases where the fill > area is too large, i could imagine. This needs to be cleaned up by > someone who knows more about that. > 3. I did not care about the more complex rectangle drawing like > buttons, where you fill the rectangle in both directions. At first > glance this seems to work anyway, at least my buttons here look OK. > 4. For disabled table header cells I need yet another caps image. This > is attached as well (for the Narcissus theme only). Note that this > only a quick draft, that looks OK here, but may need further graphical > refinement by a more enabled person than me. > 5. As I've already said, this was some quick hackery and may not be > clean in some places, in particular when it comes to drawing other > widgets than table headers and sliders. > > Hope that gets you started on fixing Camaelon anyway. > Have fun > > Andreas > > <Camaelon.diff> > <ListHeader-caps-unselected.tiff> > > > ------------------------------------------------------------------------ > > _______________________________________________ > Etoile-discuss mailing list > [email protected] > https://mail.gna.org/listinfo/etoile-discuss _______________________________________________ Etoile-discuss mailing list [email protected] https://mail.gna.org/listinfo/etoile-discuss
