On 2008-01-14 16:53:38 +0100 Fred Kiefer <[EMAIL PROTECTED]> wrote:

> Great that you started to patch this!
Well, that's how open source projects work, ain't it?

> Two comments though. In the first two changes you are doing the 
> flipping
> yourself. Wouldn't it be easier to call the method
> fillHorizontalRect:withImage:flipped: with the last parameter set to
> YES? It would be even better if Camaelong moved that isFlipped 
> parameter
> one method up, but this is a larger change.
You are probably right. As I've said this was a quick hack that
definitely needs refinement.

> The other thing is that I don't know why the clipping failed for you 
> and
> would like to get more information on that. The Camaelon code there
> again wasn't optimal. If you want to clip to a rectangle,just use
> [NSBezierPath clipRect:].
What actually happend was that if I activate this code the rectangle
is not drawn or at least it does not appear in the respective area.
But as already mentioned it did not work for horizontal rectangles
only. Vertical ones worked fine. So I suspect that there is something
missing concerning the clip area in the drawing context, but I do not
have the slightest idea how this is supposed to work anyway. Hence, I
do not know where to look at.

Thanks for the feedback so far.

Andreas

-- 
Mail: andreas dot schik at web dot de
Home: http://www.andreasheppel.de

PGP Key is available from the MIT key server (pgp.mit.edu).
RFC3156 defines security multipart formats for MIME with OpenPGP.

Attachment: pgpcRSlOeNf1W.pgp
Description: PGP signature

_______________________________________________
Etoile-discuss mailing list
[email protected]
https://mail.gna.org/listinfo/etoile-discuss

Répondre à