At 9:58 Uhr +0900 13.02.2002, Peter O'Gorman wrote:
>Jorge Acereda Maciá has written a dlcompat with the ability to dlopen dylibs.
>
>I have put it on package submissions:
>https://sourceforge.net/tracker/index.php?func=detail&aid=516734&group_id=
>17203&atid=414256
>
>Please check it out and comment on it. It needs to not break anything :)
I will take a look at it now. Sounds promising. However, it has to be
carefully checked for compatibility with the existing dlcompat.
Some comments/suggestions:
1) info files should (for now at least contain only ASCII, so "Maciá"
will have to be changed to "Macia" in it.
2) Jorge, how about renaming some of the functions to something more
descriptive, and more coherent:
"dlerror" -> "installErrorHandlers"
"reference" -> "addReference"
"validStatus" -> "isValidStatus"
"allocstatus" -> "allocStatus"
3) Why do you provide the methods
__dlGetQueue()
__dlCountList()
?
4) In dlopen, when path is NULL, you use the fake value "libdl.dylib"
without explaining why. I assume you do it to simulate the "standard"
behaviour in this case, namely returning a handle to the global
symbol space of the application. But a one line comment would be
nicer than having to guess :) E.g.
/* We specify "libdl.dylib" here since we know we have this name,
and we are linked at load time to the app, so opening it with
RTLD_GLOBAL will yield the global symbol space as the specs require.
*/
5) You use setjmp/longjmp to generate custom error messages when
undefined/multiple symbols are encountered. Is this really necessary?
If so, please explain why and comment it accordingly in the source.
I will now compile it and see how it performs.
Cheers,
Max
--
-----------------------------------------------
Max Horn
Software Developer
email: <mailto:[EMAIL PROTECTED]>
phone: (+49) 6151-494890
_______________________________________________
Fink-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/fink-devel
