Hi, Sorry for the delay, I had holidays.
On Thursday, February 14, 2002, at 06:45 PM, Max Horn wrote: > > 2) Jorge, how about renaming some of the functions to something more > descriptive, and more coherent: > "dlerror" -> "installErrorHandlers" Yes, this is an ugly hack. dlerror() is used to get the current error. It is just that I found it to be a good place to do initialization. > "reference" -> "addReference" > "validStatus" -> "isValidStatus" > "allocstatus" -> "allocStatus" Changed. > > > 3) Why do you provide the methods > __dlGetQueue() > __dlCountList() > ? These are debugging functions used from dltest.fs I could compile them conditionally if you don't like them there. > > 4) In dlopen, when path is NULL, you use the fake value "libdl.dylib" > without explaining why. I assume you do it to simulate the "standard" > behaviour in this case, namely returning a handle to the global > symbol space of the application. But a one line comment would be > nicer than having to guess :) E.g. OK, noted :-) > 5) You use setjmp/longjmp to generate custom error messages when > undefined/multiple symbols are encountered. Is this really necessary? > If so, please explain why and comment it accordingly in the source. I was unable to find a clean way to avoid an exit() when trying to resolve missing symbols. Real dl libraries just return an error, the old dlcompat left the application. _______________________________________________ Fink-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/fink-devel
