Oops, disregard that last message. I was looking at find_romentry() and indeed it makes sense to return a negative value to indicate error since it returns an index otherwise.
Acked-by: David Hendricks <[email protected]> On Fri, Aug 19, 2011 at 2:53 PM, David Hendricks <[email protected]>wrote: > Did you want to fix the inconsistent use of -1 instead of 1 as the return > code for some functions? > > Other than that it looks good (i'm biased, of course :-)) > > -- > David Hendricks (dhendrix) > Systems Software Engineer, Google Inc. > -- David Hendricks (dhendrix) Systems Software Engineer, Google Inc.
_______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
