-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Curtis Olson wrote: > Hi Tim, > > I took a peek at the diffs and had a couple questions. Originally the > idea of the fg_os files was to have a single interface within the > flightgear code so that the details could be hidden in fg_os.[ch]xx, but > I see with your changes that you have a lot of OSG specific code now > that has filtered up into the renderer.cxx. Is that needed or could > these new changes be hidden better behind fg_os like the code originally > intended? > > Thanks, > Hi Curt, renderer.cxx already contains a lot of OSG specific code; in fact it would be fair to say that is all OSG specific code. I did add some osgViewer specific code to renderer.cxx because the details of accessing the scene root, controlling the camera, and running the rendering loop are different when using a Viewer; those are concepts that fg_os doesn't handle at all.
It's possible that the osgViewer changes to renderer.cxx could be refactored a bit to be less intrusive, but I'm hoping the need for the non-osgViewer case will disappear :) In the mean time the differences between the two approaches are made obvious, which I think is good for people looking at this code. Tim -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iD8DBQFGTVPGeDhWHdXrDRURAoZaAJ462o0jI0I5HdbXXaPLd59ZSZsYjwCgjVAM KyG6cixedS/pNH9+eptsOxU= =aGBK -----END PGP SIGNATURE----- ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
