On Fri, Jan 20, 2012 at 9:59 AM, Thorsten Renk wrote: > > My GIT is now a week old, but in all likelihood this hasn't changed and is > in the release branch: > > In reaction to concerns about a confusing menu structure, I moved all > relevant configurations to > > /gui/dialogs/local_weather_tiles.xml > > (insofar as they are not controlled by the rendering dialog, which now > affects e.g. cloud visibility range). > > This means that the second dialog > > /gui/dialogs/local_weather_config.xml > > contains only obsolete options - with one important exception, which is > the checkbox determining if the Local Weather Nasal module is loaded. > > This cannot simply be moved to the other menu, because it also > de-activates the 'Local Weather' menu item, so if it is deactivated, the > only option (short of the property browser) to activate the menu would be > on the deactivated dialog. > > I don't know what the solution should be, but I don't think the current > state of offering a configuration dialog which doesn't affect anything is > very good for a release. On the other hand, it should be clearly > recognizable that the Nasal module has to be loaded before the system > becomes functional. > > If anyone of those who originally suggested that the config menu is > removed could please take care of this?
It's not clear from your mail whether the local_weather_config dialog in the release branch can be removed once this checkbox issues is resolved. Can you confirm? Also, I noticed that there's another local_weather.xml dialog under gui/dialogs that appears to be obsolete. Can you confirm that it can be deleted? I'd suggest moving the /nasal/local_weather/enabled checkbox to the top of the tiles dialog, and disabling the rest of the dialog when this is not set. That way the dialog can be available at all times, while users will not be able to set any local weather config without enabling it. Does that sound like a good solution to you? I'm happy to take a look at making this change later today. It should be very straightforward. I don't know whether this change should be in the release or not. It's pretty late in the day. -Stuart ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
