Glen, I'd like you to revert that one and take a different approach if any. handleBreak does really handle break-before AND break-after, so the name was ok. What can be is that there is some left-over code from the previous approach. I'm not sure but I think we don't even need the break-* traits anymore because this is already handled during the creation of element lists. Break-before and break-after are normalized to the startOn value held by BlockSequence.
On 05.05.2005 06:54:08 gmazza wrote: > gmazza 2005/05/04 21:54:08 > > Modified: src/java/org/apache/fop/layoutmgr Tag: > Temp_KnuthStylePageBreaking > PageSequenceLayoutManager.java > Log: > More clarifications to PSLM. > > Revision Changes Path > No revision > No revision > 126.96.36.199 +33 -34 > xml-fop/src/java/org/apache/fop/layoutmgr/PageSequenceLayoutManager.java > > Index: PageSequenceLayoutManager.java > =================================================================== > RCS file: > /home/cvs/xml-fop/src/java/org/apache/fop/layoutmgr/PageSequenceLayoutManager.java,v <snip/> > - // otherwise, we simply need a new page > - handleBreak(bIsFirstPage ? list.getStartOn() : > Constants.EN_PAGE); > + // otherwise, we may simply need a new page > + handleBreakBefore(bIsFirstPage ? list.getStartOn() > : Constants.EN_PAGE); <snip/> Jeremias Maerki