Hi Jay, First, congratulations for this new feature! This is a great addition to FOP.
A few remarks about your commit: - I suggest you to install and setup checkstyle if you haven't done yet; - don't forget to add the ASF headers (checkstyle will notify you about that, BTW) and set the "svn:keywords Id" and "svn:eol-style native" on new files. - if your modifications are non-trivial (as is the case here), it's very important to add a note about them in the status.xml file. The content of this file appears on the following web page: http://xmlgraphics.apache.org/fop/changes.html This is a key page for our users to follow FOP's evolutions. If the change is important and deserves to be highlighted in the release notes of the next version (as, again, is the case here), you should add the importance="high" attribute to the entry. See for example here: http://xmlgraphics.apache.org/fop/0.93/releaseNotes_0.93.html I've added an entry for named destinations, feel free to improve it if needed (for example, it might be good to explain the net result for users). Thanks, Vincent > Author: vhennebert > Date: Tue Apr 3 01:14:05 2007 > New Revision: 525078 > > URL: http://svn.apache.org/viewvc?view=rev&rev=525078 > Log: > - fix minor checkstyle issues > - add missing headers > - add an entry in status.xml for the new named destinations feature
