Great addition, I agree, but is it supposed to work? I tried it out and
although some new elements are generated in the PDF the destinations
don't work. The elements generated also look a little different than in
0.20.5, and I'm not referring to the fact that currently we only
reference pages and not coordinates on pages. Jay, is the feature fully
implemented or are any things missing?

On 03.04.2007 10:41:27 Vincent Hennebert wrote:
> Hi Jay,
> First, congratulations for this new feature! This is a great addition to
> FOP.
> A few remarks about your commit:
> - I suggest you to install and setup checkstyle if you haven't done yet;
> - don't forget to add the ASF headers (checkstyle will notify you about
>   that, BTW) and set the "svn:keywords Id" and "svn:eol-style native" on
>   new files.
> - if your modifications are non-trivial (as is the case here), it's very
>   important to add a note about them in the status.xml file. The content
>   of this file appears on the following web page:
>   This is a key page for our users to follow FOP's evolutions. If the
>   change is important and deserves to be highlighted in the release
>   notes of the next version (as, again, is the case here), you should
>   add the importance="high" attribute to the entry. See for example
>   here:
>   I've added an entry for named destinations, feel free to improve it if
>   needed (for example, it might be good to explain the net result for
>   users).
> Thanks,
> Vincent
> > Author: vhennebert
> > Date: Tue Apr  3 01:14:05 2007
> > New Revision: 525078
> > 
> > URL:
> > Log:
> > - fix minor checkstyle issues
> > - add missing headers
> > - add an entry in status.xml for the new named destinations feature

Jeremias Maerki

Reply via email to