On Tue, Apr 03, 2007 at 05:25:15PM +0100, Adrian Cumiskey wrote:
> Hi,
> I have had a good look through the code, changed the interface in my 
> sandbox and I can find no reason why
> org.apache.fop.render.Renderer#void startPageSequence(LineArea title)
> shouldn't instead be
> org.apache.fop.render.Renderer#void 
> startPageSequence(org.apache.fop.area.PageSequence pageSeq).

The title area is special in that it is not part of the page
areas. That is why it has to be passed to the renderer out of
band. The other areas will be passed to the renderer in the process.

In general it is good to pass as little information as needed, to keep
interdependencies to a minimum. "Finding no reason why" is not a good
enough reason to pass more information. The need for the PostScript
renderer to access that information must be good enough to argue for
such a change.

> Of course this would mean a change in a low level interface but would be 
> a trivial change for all our renderers.
> The reason why this is important is that the implementing renderer may 
> need to do some initial preparation work before page processing (e.g. in 
> my case the postscript renderer may want to access some extensions that 
> have been defined as children of the simple page master prior to 
> processing the individual pages in its sequence).  I don't think I'm 
> missing something here..  Speak now or forever hold your peace :-)

Little hope.

Regards, Simon

Simon Pepping
home page: http://www.leverkruid.eu

Reply via email to