--- Comment #4 from Andreas L. Delmelle <[EMAIL PROTECTED]>  2008-11-30 
03:47:49 PST ---

Adding my response to Peter's suggestions here too:

> Here are the changes I did
> 1. PDFLink#toPDFString
> Added
>      this.action.setParent(this);
> (would be better to do this when creating the PDFUri object )

Or maybe, we should do this in PDFLink#setAction() ?

That seems to be the point where the PDFAction (PDFUri) is associated with the

I already checked whether this had unwanted side-effects when the same URI is
used in multiple links, but that does not seem to be the case. The parent link
is only used to get to the ancestor document, which is obviously the same for
all links.

> 2. PDFUri#getAction
> <snip />
> 3. Added PDFObject#encodeText2

I'm wondering to what extent this new, separate method could be merged with the
original encodeText(), maybe by changing the signature, and adding a second
parameter to distinguish this case from the one covered by the original method.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to