I think it should be safe to make them private. If there's a reason to make the protected we'll hear about it soon.
On 30.11.2008 23:22:49 Andreas Delmelle wrote: > On 30 Nov 2008, at 23:12, [EMAIL PROTECTED] wrote: > > > https://issues.apache.org/bugzilla/show_bug.cgi?id=41959 > > <snip /> > > > > I'll try to post a patch shortly, but it seems I've made a rather > > large number > > of other unrelated changes (mostly minor cleanups) to the code, > > which would > > only confuse people... > > Regarding those 'cleanups', I noticed that all of the object lists in > PDFDocument currently are protected. Does this have a reason? I > changed most of the protected instance variables to private, since > they didn't reveal any dependencies within FOP (= all necessary access > goes via the public accessors). > > Are there implementors I should be aware of here? > > > Andreas Jeremias Maerki
