Hi Guys, I was tasked with fixing this issue, and spent some time cleaning up and testing this area of code. I really don't want to get in the middle of this but if any one has any questions or wishes to make amendments, feel free to do so, or suggest improvements and I'll amend the patch.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51596 Mehdi On 31 July 2011 10:23, Andreas L. Delmelle <andreas.delme...@telenet.be> wrote: > On 28 Jul 2011, at 14:33, Peter B. West wrote: > >> On 28/07/2011, at 9:59 PM, Vincent Hennebert wrote: >> >>> By putting it at a non-expected place you’re making it difficult to find >>> the variable and understand in a quick glance what the class is made of. >>> This hampers the readability and maintainability of the code. Given that >>> it’s what we spend most of our time on, I find this worrying. >> >> That is, by assisting the understanding of the use of this variable, you >> have made it harder to "understand in a quick glance." But in any case... > > That is: "By putting it at place where I did not expect it, you are making it > difficult for normal people, like me, to find it --because, well, it is then > located near to where it is actually used-- and understand in a quick glance > [...] I find this worrying --and did not care much for _your_ intentions > either way." > > And then, a bit later: > > On 29 Jul 2011, at 12:57, Vincent Hennebert wrote: > >> I don’t think I was attacking anyone. I realise that there is bad past >> experience about this, but I don’t believe anything similar happened >> here. I’m sorry if my message sounded confrontational. > > "I did not do anything wrong! Sorry if that was too confrontational. Can we > play nice again? Can we? Please?" > >> I suppose I could write a whole chapter about how I am affected by >> unreadable and unmaintainable code in FOP almost on a daily basis; About >> the anger, the frustration, and sometimes the total despair that result >> from this. But I’ll refrain to this paragraph. > > "I suppose I could write a whole chapter about how I am affected by the awful > mess you old-timers have left me with. The voices, the nightmares, the > hair-ripping... but I will remain civil, because I am perfect and never do > anything wrong. No, really. It's true. Everyone who agrees with me, says so." > > > > Regards, > > Andreas > ---