Hi Shawn, I created an implementation of Enmasse part for FC-144. I added new group-related methods for group-related CRUD operations, list of group roles and list of role groups and ability to create session with group. There're also minor changes related to refactoring of tests in this package.
At the moment I pushed it to my forked copy of the main repo there: https://github.com/vvakhlyuev-work/directory-fortress-enmasse/commit/a85704b7f5d8e88fb24529e81866416ab2ab9061 Could you please review it and provide a feedback? Meanwhile, I'm going to commit a more or less final version of the code to Fortress Core repo (my forked copy). Thank you in advance! On Mon, Aug 29, 2016 at 3:29 PM, Shawn McKinney <[email protected]> wrote: > > > On Aug 28, 2016, at 1:53 PM, Vyacheslav Vakhlyuev < > [email protected]> wrote: > > > > I've created an initial implementation of the functionality described in > > this thread. > > At the moment I pushed it to my forked copy of the main repo there: > > https://github.com/vvakhlyuev-work/directory-fortress-core/commit/ > 098f0a37b69be2cf76fa8d6e23ef3d250ccf58fc > > Could you please review it and provide a feedback? > > > > There's still more work to do: add REST managers, update console > managers, > > add new unit-tests etc., but I want to make sure that I'm on the right > way. > > Thank you in advance! > > Hello Vyacheslav, > > I did a quick code review and it looks like you’re on the right track. > Good work! > > Thanks, > Shawn -- Kind Regards, Vyacheslav Vakhlyuev Software Engineer Mirantis, Inc www.mirantis.com Skype: vahluev.vyacheslav
