On Mon, Sep 26, 2016 at 4:16 PM, Shawn McKinney <[email protected]> wrote:
> Hello Vyacheslav, > > It’s an excellent effort. Good attention to project coding and testing > conventions. Good understanding of the underlying framework. As a > post-mortem I’d like feedback from you wrt to how we can improve but > there’s time for that later. Thank you, Shawn! I'll start working on a feedback soon. > > > The code looks really good. The core's unit tests pass. I haven’t run > through enmasse / multitenancy yet. In the meantime - go for it. > I've just opened pull-requests. ASF GitHub Bot has already commented on this for me in Jira issue :) -- Kind Regards, Vyacheslav Vakhlyuev Software Engineer Mirantis, Inc www.mirantis.com Skype: vahluev.vyacheslav
