Hi Shawn, I added a new commit to the forked copy of Fortress core. It adds tests for new GroupMgr methods, modified SSD and DSD checks for Group-type entities and some minor changes (HttpIds, renamed/overloaded AccessMgr.createSession( Group ) method etc.) Here's a link to the commit: https://github.com/vvakhlyuev-work/directory- fortress-core/commit/252e6116933c7d37d53159c304fdb1e309a97aa1
Also, there's a minor change to EnMasse related to method rename in Core project: https://github.com/vvakhlyuev-work/directory- fortress-enmasse/commit/3eb9754290ced641b9a303b356cd6031165a02cc Overall, I think these commits finalize the changes I need to do for FC-144. Could you please review the changes located in "FC-144/assign-roles-for-groups" branches in my forked copies? If you find everything is OK, I will open a pull-request to merge these changes. Here're links: Fortress Core: https://github.com/apache/directory-fortress-core/compare/master...vvakhlyuev-work:FC-144/assign-roles-for-groups Fortress EnMasse: https://github.com/apache/directory-fortress-enmasse/compare/master...vvakhlyuev-work:FC-144/assign-roles-for-groups One more thing regarding Realm project. I modified versions of Core and EnMasse to "1.0.2-SNAPSHOT" in their pom.xml files. I also modified EnMasse pom to require Realm "1.0.2-SNAPSHOT". However, I didn't commit any changes to Realm project, so an additional change will be needed there. Thank you in advance for you comments! On Wed, Sep 14, 2016 at 9:46 PM, Shawn McKinney <[email protected]> wrote: > > > On Sep 14, 2016, at 1:42 PM, Shawn McKinney <[email protected]> > wrote: > > > > > > throw new SecurityException( GlobalErrIds.GROUP_TYPE_INVLD, > info ); > > > > or perhaps even better…. > > > throw new ValidationException( GlobalErrIds.GROUP_TYPE_INVLD, info ); > -- Kind Regards, Vyacheslav Vakhlyuev Software Engineer Mirantis, Inc www.mirantis.com Skype: vahluev.vyacheslav
