> On Sep 8, 2016, at 12:39 PM, Vyacheslav Vakhlyuev <[email protected]> > wrote: > > I created an implementation of Enmasse part for FC-144. > I added new group-related methods for group-related CRUD operations, list > of group roles and list of role groups and ability to create session with > group. > There're also minor changes related to refactoring of tests in this package. > > At the moment I pushed it to my forked copy of the main repo there: > https://github.com/vvakhlyuev-work/directory-fortress-enmasse/commit/a85704b7f5d8e88fb24529e81866416ab2ab9061 > Could you please review it and provide a feedback? >
Vyacheslav, it looks like you have mapped the core’s groupMgr assignRole (new) methods to accessmgr.assignUser inside enmasse? Is that correct? I’d say it should pass through the groupmgr services. The general rule, every public api in a core’s mgr, there is one service in the corresponding enmasse impl class by the same name. Also a nit is in accessMgr.createGroupSession, I’d just overload the createSession passing the Group. I haven’t looked at the gritty details but other than that I think you’re still on the right track. Thanks, Shawn
