On 8/3/2016 9:24 AM, Jan Danielsson wrote:
For those who are afraid of new features messing with your current setup: The jan-manifest-tags branch is explicitly designed to not interfere with your current setup. You need to take action for a change to occur. If you use "set manifest on" or "set manifest off" it will work exactly like it always has. I.e. if you don't care about this feature, you - as an end user - will not notice it's there (apart an updates settings field and help text).
I just built it and ran the existing test suite over it on Windows. It passes all existing tests. I didn't spot any test cases for the new feature. While I don't see that as blocking a merge to trunk (it didn't break any existing tested feature) I do think that we should write some test cases for the new treatment of the manifest setting, as well as the new tag manifest before the next "release" of fossil after this feature is merged.
I'm not sure offhand how our test coverage looks for all settings. Writing tests that cover every setting is probably a worthy goal for a long term and low priority project for someone who wants to visit all the nooks and crannies in the fossil source kit.
-- Ross Berteig [email protected] Cheshire Engineering Corp. http://www.CheshireEng.com/ +1 626 303 1602 _______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
