On 8/6/2016 12:02 PM, Jan Danielsson wrote:
On 05/08/16 02:51, Ross Berteig wrote: Many thanks; this saved me a lot of time, as a non-native tcl speaker. And as such, I also would like someone to quickly look over the additions I've made. It seems to work, but I have a feeling I have have reinvented the wheel.
Your additions look fine to me, but I too am a non-native Tcl speaker.
.... I added more tests in the same file, but given the "set-" prefix I assume it would have been better to split the manifest.tags content tests to a separate test. On the other hand, there aren't many tests overall so it doesn't hurt having them all in a single file for now.
This file seems sensible to me. My logic is that the feature here is the effect of the "manifest" setting. It originally just controlled whether the
If anything, I should add a few tests related to the specific content of the other two kinds of manifest files that are all controlled by the single manifest setting.
I think I'll lean on your new file_contains function to do that for manifest. The manifest.uuid is easy to compare to the output of fossil info.
-- Ross Berteig [email protected] Cheshire Engineering Corp. http://www.CheshireEng.com/ +1 626 303 1602 _______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
