On 05/08/16 02:51, Ross Berteig wrote: [---] > I just created test cases for fossil set manifest that verify that the > files manifest, manifest.uuid, and manifest.tags appear and disappear as > the setting is changed. I did not verify that any of the files have the > right content.
Many thanks; this saved me a lot of time, as a non-native tcl speaker. And as such, I also would like someone to quickly look over the additions I've made. It seems to work, but I have a feeling I have have reinvented the wheel. >> I'm not sure offhand how our test coverage looks for all settings. >> Writing tests that cover every setting is probably a worthy goal for a >> long term and low priority project for someone who wants to visit all >> the nooks and crannies in the fossil source kit. > > On the assumption that there will be more tests related to settings, I > named the new file test/set-manifest.test so there is an obvious naming > pattern to follow for tests of other features primarily exposed through > settings. I added more tests in the same file, but given the "set-" prefix I assume it would have been better to split the manifest.tags content tests to a separate test. On the other hand, there aren't many tests overall so it doesn't hurt having them all in a single file for now. -- Kind Regards, Jan _______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
