Wichert Akkerman wrote:
I have completed implementation of PLIP 195. Aside from a number of
cleanups and bugfixes there is one important change:
the GenericSetup setup tool now has a separate method to calculate the
dependency chain for a profile. CMFQuickInstaller has been updated to
use this method to check if all dependencies for a product are
available. If not it will mark the product as not-installable. To
demonstrate this I added a test product called 'BrokenProduct' to the
review bundle.
Hi Wichert,
thanks for this.
Here some notes from my very first impression:
1. I might be missing the obvious but I don't see
the 'BrokenProduct' you mention in the review bundle.
What I have is the following (new checkout):
[EMAIL PROTECTED]:~/buildouts/reviewing/plip195-dependencies$ svn info
Path: .
URL: https://svn.plone.org/svn/plone/review/plip195-dependencies
Repository Root: https://svn.plone.org/svn/plone
Repository UUID: 3b4cdb85-528f-c531-b63d-5919d5b1aa08
Revision: 18955
Node Kind: directory
Schedule: normal
Last Changed Author: wichert
Last Changed Rev: 18955
Last Changed Date: 2008-01-15 12:08:06 +0100 (Tue, 15 Jan 2008)
where
[EMAIL PROTECTED]:~/buildouts/reviewing/plip195-dependencies$ ls products/
CMFQuickInstallerTool GenericSetup ProductTwo
EXTERNALS.txt ProductOne
But don't worry too much. I tested the new feature with
two products of mine (CMFBib and ATExtensions) and it
works as advertised. Just wanted to let you know this.
2. Not sure it's the best possible UI to completely hide a
product if a dependency is missing. Maybe it would be
more helpful to list the product as broken and tell the
reason so people won't start asking questions why the
add-on they just installed doesn't show up on the products
configlet. IIRC we do (did?) something similar when the
install is broken (typically because of a typo) at least
when running in debug mode (which I was while testing).
3. Don't think it matters at all but I noticed you're using
Plone 3.0.4 in the buildout.cfg while 3.0.5 is out since
a week. I leave it to you to decide whether you want to
update this.
Thanks again for a most useful improvement.
I'll get back once I've looked more closely at the
implementation,
Raphael
Wichert.
_______________________________________________
Framework-Team mailing list
[email protected]
http://lists.plone.org/mailman/listinfo/framework-team
