Raphael Ritz wrote:
Wichert Akkerman wrote:
I have completed implementation of PLIP 195. Aside from a number of cleanups and bugfixes there is one important change: the GenericSetup setup tool now has a separate method to calculate the dependency chain for a profile. CMFQuickInstaller has been updated to use this method to check if all dependencies for a product are available. If not it will mark the product as not-installable. To demonstrate this I added a test product called 'BrokenProduct' to the review bundle.



Hi Wichert,

thanks for this.

Here some notes from my very first impression:

1. I might be missing the obvious but I don't see
  the 'BrokenProduct' you mention in the review bundle.

Seems I forgot to commit that part. Oops. I have added it now.

2. Not sure it's the best possible UI to completely hide a
product if a dependency is missing. Maybe it would be
more helpful to list the product as broken and tell the
reason so people won't start asking questions why the
add-on they just installed doesn't show up on the products
configlet. IIRC we do (did?) something similar when the
install is broken (typically because of a typo) at least
when running in debug mode (which I was while testing).

I'ld like some input from Hanno on that. What I did was update the isInstallable method in the quickinstaller tool, which seemed the logical place to put it and makes sure all the standard APIs and code paths do the right thing. QI has never had a user interface or API that communicates why a product is not installable and I'm not sure what the best way to add this is.

Perhaps the simplest solution is to add a method that returns a list of broken products and show that in the user interface.


3. Don't think it matters at all but I noticed you're using
Plone 3.0.4 in the buildout.cfg while 3.0.5 is out since
a week. I leave it to you to decide whether you want to
update this.

I did that when trying to track down a somewhat mysterious error and wanted to verify all changes since December. Everything works just as well with Plone 3.0.5 though.

Thanks again for a most useful improvement.
I'll get back once I've looked more closely at the
implementation,

Thanks! I'm looking forward to the feedback.

Wichert.


--
Wichert Akkerman <[EMAIL PROTECTED]>   It is simple to make things.
http://www.wiggy.net/                  It is hard to make things simple.


_______________________________________________
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team

Reply via email to