On 26 Aug, Mo DeJong wrote:
> Hi all.
>
> I have been chasing down a little bug that was keeping me
> from using freeamp to pull mp3 files off a web server.
> The odd part was that it worked just fine with winamp
> but when I connected with freeamp the webserver puked
> saying the GET line was invalid.
>
> At any rate, I was able to get the GET method sent
> out by freeamp to work with the sever by adding a
> \r before the \n in the GET line. I think the RFC
> says that you need both \r and \n, but there are
> at least some web servers that are really picky
> about this. This patch was enough to get things
> working. It would really be better to add a \r
> to all the header bits that just use \n now, but
> I will leave that up to you developers.
Groan is right. At first I had everything with just \n. Then someone
pointed out that the HTTP spec calls for \r\n. I checked it out and
agreed and applied the change. Then people started reporting that it was
not working with proxies anymore. Not having had any bad feedback with
just the \n (other than not being compliant) I went back to that. Sigh.
However, your solution with just the first line having the \r\n is not
something I've tried. What made you decide to do just the first line?
What I will do when I get back from Burning Man is to build a version
with your fix and then send it to the people that were having problems.
If they are happy, then I will apply your patch. If they are not happy,
I will go with Sean's suggestion and add a checkbox to the options
dialog.
Sound fair?
--ruaok Freezerburn! All else is only icing. -- Soul Coughing
Robert Kaye -- [EMAIL PROTECTED] http://moon.eorbit.net/~robert
_______________________________________________
[EMAIL PROTECTED]
http://www.freeamp.org/mailman/listinfo/freeamp-dev
