On Sat, Jun 08, 2002 at 02:45:06PM +1000, Bruce Evans wrote: > On Fri, 7 Jun 2002, Brooks Davis wrote: > > > On Fri, Jun 07, 2002 at 02:16:45PM -0700, Brooks Davis wrote: > > > On Fri, Jun 07, 2002 at 01:30:37PM -0700, David O'Brien wrote: > > > > On Fri, Jun 07, 2002 at 12:59:55PM -0700, Brooks Davis wrote: > > > > > Applying phk's patch seems to have fixed it. It's a bit overkill for > > > > > fixing dump, but it did work and I guess this way I can do some limited > > > > > testing of the ufs2 patch. > > Is that the full ufs2 patch? phk also committed a quick fix for dump.
That's with the full ufs2 patch. > > Here's a sample of the errors I'm seeing: > > > > DUMP: read error from /dev/ad0s2f: Invalid argument: [sector -1980991191]: >count=-1 > > DUMP: read error from /dev/ad0s2f: Invalid argument: [sector -1980991190]: >count=-1 > > ... > > I saw similarly bogus sector (block) numbers when I first debugged this > problem. They were caused by missing prototypes. 32-bit block numbers > were passed to unprototyped functions that expected daddr_t block numbers. > When daddr_t was changed to 64 bits, there was garbage in the top 32 bits. > > dump doesn't compile cleanly at a high WARNS level, so now would be a good > time to WARNSify it. That sounds like a good idea. If someone else doesn't get there first, I'll take a look at that soon. If nothing else, there's the plane trip down to SFO for USENIX. -- Brooks -- Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4
Description: PGP signature