Follow-up Comment #8, bug #13810 (project freeciv):

I meant "pset" only for the variable names; functions
structs, etc. should have "setting". The variable name
should usually give some hint as to what it stands for.
So "cmd", when the type is "struct setting *", would
not be a good variable name (someone would think it
was a "struct command").

Also, do not do this

> pset_sval_validate(cmd)(arg, caller, &reject_message)

Just make the wrapper like

  setting_string_validate(pset, arg, ...)

and have it call the validate function if it exists,
i.e., if the function pointer is not NULL it returns
the return value of the call, otherwise it returns TRUE.


----------------------------------------------------------------
注意して読みなさい。

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?13810>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to