Follow-up Comment #9, bug #13810 (project freeciv):

> _(pset_short_help(i))

Why not put the _() in setting_short_help() and write
in the comment header that it returns the translated
version? This goes for all such dupicated expressions.

Why do you use the setting number as first argument
to almost every setting function? The only function
that takes a setting id should be setting_by_number().

> for (i = 0; i < SETTINGS_NUM; i++) {

Use an iteration macro, either as the for loop or
using the generic iterator interface in utility/
iterator.h. Iterate on 'pset' which is a 'struct
setting *'.



Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to