Summary: unit_change_homecity_handling() teleports units
                 Project: Freeciv
            Submitted by: pepeto
            Submitted on: Thursday 07/30/2009 at 13:08
                Category: general
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
        Operating System: None



When I was reading the bug #14017 report, I noticed with surprise that units
changing homecity were teleported to this location.  This behaviour has been
added at revision 10398 for PR#12950 in a patch by Per.  This change is not
documented or explained and it seems that Per doesn't remember why he did

After checking, the function unit_change_homecity_handling() is called by 2
* handle_unit_change_homecity(): so the unit needs to be at homecity tile.
* transfer_unit(): in this case, the unit doesn't need to be at the homecity
tile.  But also, transfer doesn't mean teleport, the function header only
says: "Change home city of a unit with verbose output".

This bug is also the cause of the PR#34672.


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to