URL:
<http://gna.org/bugs/?15499>
Summary: Wrong handle of the illness_trade stuff
Project: Freeciv
Submitted by: pepeto
Submitted on: samedi 27.02.2010 à 13:30
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: S2_2
Discussion Lock: Any
Operating System: None
Planned Release: 2.2.1
_______________________________________________________
Details:
if (has_capability("trade_illness", our_capability)) {
pcity->illness_trade = packet->illness_trade;
} else {
freelog(LOG_ERROR, "Missing capability: 'trade_illness'.");
pcity->illness_trade = 0;
}
is the current part of the code. However, it is wrong on several points:
* The tests affect the client capability, which will always return TRUE
because we have this capability. The server would affect the server
capability (client.conn.capability).
* There shouldn't be an error message here, because connecting any 2.0 server
is legal. In that case (the server doesn't have the capability), the client
should read the illness field that has been sent.
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?15499>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
