On 16.09.2012 14:38, Michael T. Pope wrote: > On Sat, 15 Sep 2012 10:01:59 AM Michael Vehrs wrote: > >> On 03.09.2012 05:14, Michael T. Pope wrote: >> >>> [Colony is a GoodsLocation, and therefore a UnitLocation, but it does >>> *not* use the units list inside UnitLocation] >>> > >> Yes, we should make certain of that. But how? Will tests be sufficient? >> Do we need an AbstractUnitLocation, so that classes that do not use the >> standard unit list can inherit from that? I suspect the latter would be >> the approach approved by the OO methodologists. >> > I expect you are right about OO methodology. However it seems a little > premature to introduce a new abstraction to cover only one exception from a > norm. My work-avoidance rule of thumb is to wait until there are at least > three distinct cases:-), so I was thinking of just a few more emphatic warning > comments for now. Your call here. > > Cheers, > Mike Pope >
Sounds sensible. I hope I have not introduced any new serialization bugs. At any rate, I added a new type of test to check for serialization problems. I could start work on eliminating the GoodsContainer, if you think it worthwhile. If not, I think I'll have a look at the map editor, which seems to have bitrotted. Regards Michael ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://ad.doubleclick.net/clk;258768047;13503038;j? http://info.appdynamics.com/FreeJavaPerformanceDownload.html _______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
