Hi!

21-Фев-2004 13:17 [EMAIL PROTECTED] (Kenneth J. Davis) wrote to
[EMAIL PROTECTED]:

KJD> Please change the two lines in sys.c that use (int *) to use (UWORD *) or
KJD> similar. I overlooked this when compiling with MS VC 6 and causes the
KJD> resulting  floppy to not be able to boot as the wrong location is written
KJD> to (as int == DWORD instead of WORD).

     Wow! Missing portability in action. :)

KJD> I like the cleaned up command processing, though there is one
KJD> or two spots that need fixing:
KJD>     printf("%s: drive %c must be A:..Z:\n", pgm, *argv[(argc == 3 ? 2 :
KJD> 1)]);
KJD> should probably be
KJD>     printf("%s: drive %c must be A:..Z:\n", pgm, argv[drivearg][0]);

     And:

        #define PGM "SYS"
        printf (PGM ": drive %c ...", argv [...

And, instead

#ifdef DEBUG
  /* there's a zero past the kernel name in all boot sectors */
  printf("Boot sector kernel name set to %s\n", &newboot[0x1f1]);

should be

#ifdef DEBUG
  printf("Boot sector kernel name set to %.11s\n", newboot + 0x1f1);

Etc.




-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id56&alloc_id438&op=click
_______________________________________________
Freedos-kernel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/freedos-kernel

Reply via email to