On Wed, 2014-07-02 at 15:21 +0200, Petr Spacek wrote: > On 2.7.2014 14:57, Martin Basti wrote: > > On Tue, 2014-07-01 at 12:23 +0200, Petr Spacek wrote: > >> On 1.7.2014 12:20, Martin Kosek wrote: > >>> On 07/01/2014 10:55 AM, Petr Spacek wrote: > >>>> On 1.7.2014 10:49, Petr Viktorin wrote: > >>>>> On 07/01/2014 10:43 AM, Petr Spacek wrote: > >>>>>> On 30.6.2014 17:10, Martin Basti wrote: > >>>>>>> On Mon, 2014-06-30 at 16:57 +0200, Petr Spacek wrote: > >>>>>>>> On 30.6.2014 14:33, Martin Basti wrote: > >>>>>>>>> On Mon, 2014-06-30 at 12:49 +0200, Martin Basti wrote: > >>>>>>>>>> Patch attached. > >>>>>>>> > >>>>>>>> It works for me. > >>>>>>>> > >>>>>>>> Please change the string little bit, I have realized that we should > >>>>>>>> ensure > >>>>>>>> that file permissions are correct: > >>>>>>>> > >>>>>>>> chown named: * > >>>>>>>> chmod u= * > >>>>>>>> > >>>>>>>> (the chmod part new) > >>>>>>>> > >>>>>>>> Thanks! > >>>>>>>> > >>>>>>> > >>>>>>> Updated patch attached > >>>>>> > >>>>>> I'm really sorry, I had to change the message once again :-) > >>>>>> > >>>>>> None of us noticed that chmod command was completely incorrect. I'm > >>>>>> attaching fixed patch as an apology. > >>>>>> > >>>>>> It works for me when applied to master > >>>>>> (50c30c8401c21d43414404bd5caa157196449e4c). > >>>>>> > >>>>>> Functional self-ACK :-) > >>>>>> > >>>>>> IMHO it can be pushed if Python-review is okay. > >>>>> > >>>>> Once again, please define new message classes in messages.py instead of > >>>>> just > >>>>> using PublicMessage with a custom string. > >>>>> > >>>>> Also, these messages will work for console output, but I'm not sure > >>>>> pre-wrapped text would look good in web UI. > >>>>> I'm not sold on the idea of giving instructions in warning messages. > >>>>> Would a > >>>>> link to some documentation be better? > >>>> > >>>> Well, the idea was to provide copy&paste instructions directly in the > >>>> console, > >>>> not speaking about problems with URLs downstream. > >>>> > >>>> If you insist on URL ... here it is: > >>>> http://www.freeipa.org/page/Releases/4.0.0#Experimental_DNSSEC_Support > >>>> > >>> > >>> Please use something more stable, like > >>> > >>> http://www.freeipa.org/page/DNSSEC > >>> > >>> which we would use as a gathering place for information about FreeIPA and > >>> DNSSEC. > >> > >> IMHO this particular warning should point to version-specific information. > >> > >> I'm not opposing to /page/DNSSEC idea in general but this warning should > >> point > >> to very specific steps which will be valid only to very specific version of > >> FreeIPA. > >> > > > > Updated patch attached > > I have bad news for you: Patch > freeipa-mbasti-0083-4-DNSSEC-experimental-support-warning-message.patch > > cannot be applied on top of: > > current master (01b95805ab1428e10c79abf70c9bc9e2baf9de21) > freeipa-mbasti-0080-Allow-to-add-non-string-values-to-named-conf.patch > freeipa-mbasti-0081-DNSSEC-Add-experimental-support-for-DNSSEC.patch > freeipa-mbasti-0082-Add-warning-about-semantic-change-for-zones.patch >
You need 0082-2 -- Martin^2 Basti _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
