On 08/10/2015 06:22 PM, Milan Kubík wrote:
NACK again. The problem is the reference counting. Even with this patch,
there seems to be at least one reference left after 't' is deleted and
nss.nss_shutdown races with the garbage collector.
On 08/10/2015 06:02 PM, Milan Kubík wrote:
On 08/10/2015 05:54 PM, Jan Cholasta wrote:
On 10.8.2015 17:43, Milan Kubík wrote:
this patch fixes problem described in the ticket 
that caused the test run to fail completely at every other or so run.
I took the liberty to fix most of the pep8 issues while I was at it.
Thanks to Jan Cholasta for help with identifying this one.
IMO this would be more robust:
t = None
By assigning a value to the variable at the beginning you make sure
that the del statement will not fail.
Thanks for the idea. It also removed the version check.
Updated patch attached.
I have updated the fix for all of the leaks in that class. It seems to
corrupt the database even when no init/shutdown was called. Just not
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code