Please ignore that mail, I sent an unfinished draft by mistake. On 10/06/2015 12:02 PM, Petr Viktorin wrote: [...] > > OK, changed. > > >>>> Patch 724: >>>> >>>> The SSHPublicKey class was written with the assumption that "str" means >>>> binary data, so unless I'm missing something, you only need to replace >>>> "str" with "bytes". >>> >>> It specifically did take non-binary data as str: >>> >>> - if isinstance(key, str) and key[:3] != '\0\0\0': >>> - key = key.decode(encoding) >> >> I don't follow, this is quite obviously binary data. It reads: "If key >> is binary and does not start with 3 null bytes, decode it to text using >> the specified encoding." > > Sorry, I meant binary data. >
-- Petr Viktorin -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
