URL: https://github.com/freeipa/freeipa/pull/174
Title: #174: add log module

shanyin commented:
"""
What do you mean is that I should send the log codes as separate PR? If so, I 
will do it later.





------------------
祝:
    工作顺利!生活愉快!
--------------------------
长沙研发中心 郑磊 
电话:18684703229
邮箱:zheng...@kylinos.cn
公司:天津麒麟信息技术有限公司
地址:湖南长沙市开福区三一大道工美大厦十四楼
 

 
 
 
------------------ Original ------------------
From:  "mbasti-rh"<notificati...@github.com>;
Date:  Tue, Nov 15, 2016 01:56 AM
To:  "freeipa/freeipa"<free...@noreply.github.com>; 
Cc:  "shanyin"<zheng...@kylinos.cn>; "Mention"<ment...@noreply.github.com>; 
Subject:  Re: [freeipa/freeipa] add log module (#174)

 

Hello,
 
we agreed on devel meeting that this is not the right way how to audit/log 
inspection should be done with FreeIPA:
  
centralized logging is preferred solution
  
However we would like to merge some parts of your PR:
  
fix for missing translation strings
 
improvement of logging that might help you and can improve value of logs for 
users Would be awesome if you can send them as separate PR.
  
Also we endorse you to create an IPA httpd log parser as separate CLI project 
from this PR which may be helpful for other users as lightweight solution 
compared to centralized logging.
 
Thank you!
 
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/174#issuecomment-260522728
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to