Hi, I don't have a device to test, but that's good news, thanks! I reviewed that code and have the following comments:
1. We should not need WITH_SCARD compile-time option. Whether smartcard is on/off depends on whether the sub-plugin is loaded successfully or not. So the codes in rdpdr_scard.c/h should move into the smartcard sub-plugin. Actually I don't quite understand why this is even needed, because it looks like it just wait for the smartcard to finish and send a completion message. It should be able to integrated into sub-plugin and current irp_queue. 2. If 1. is done, then we don't need to add srv->scard_* Any comments? Vic On 04/30/2011 05:39 AM, Eduardo Beloni wrote: > Hello, > > We've been working in the smart card redirection. So far, our tests have > produced great results, so we think it is time to ask you to take a look and > test it. Here is the branch: > > https://github.com/OSSystems/FreeRDP/tree/wip%2Fsmartcard > > Please comment on the API integration, debugging issues or anything else you > may think of. > > Thank you > > Eduardo Fiss Beloni > 55 53 8117 8244 ------------------------------------------------------------------------------ WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd _______________________________________________ Freerdp-devel mailing list Freerdp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freerdp-devel
