On Sat, Apr 30, 2011 at 01:35, Vic Lee <ll...@163.com> wrote:
...
> 1. We should not need WITH_SCARD compile-time option. Whether smartcard
> is on/off depends on whether the sub-plugin is loaded successfully or
> not. So the codes in rdpdr_scard.c/h should move into the smartcard
...

I disagree. To compile the plugin we need pcsc and thus new
dependencies. For some use cases (embedded OSs and like) this is not
desired since increase the amount of code needing porting and support.

The rest of suggestions to move the code into the subplugin I fully
agree and will ask Eduardo do look at it.

-- 
Otavio Salvador                             O.S. Systems
E-mail: ota...@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
Freerdp-devel mailing list
Freerdp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freerdp-devel

Reply via email to