Hello, --- On Sat, 30/4/11, Vic Lee <ll...@163.com> wrote:
> Hi, > > I don't have a device to test, but that's good news, > thanks! I reviewed > that code and have the following comments: > > 1. We should not need WITH_SCARD compile-time option. > Whether smartcard > is on/off depends on whether the sub-plugin is loaded > successfully or > not. So the codes in rdpdr_scard.c/h should move into the > smartcard > sub-plugin. Actually I don't quite understand why this is > even needed, > because it looks like it just wait for the smartcard to > finish and send > a completion message. It should be able to integrated into > sub-plugin > and current irp_queue. > 2. If 1. is done, then we don't need to add > srv->scard_* > > Any comments? I wish it could be that simple, but according to the documentation, "Smart Card Redirection is an asynchronous client/server protocol". So, if I'm not mistaken, it isn't something that we can check fds, or stuff like we are doing for the other plugins. I just can't find so far a more simple way to process smart card requests but enqueue irp's up and creating threads for their processing. And, for example, the protocol doesn't call a "create" for the smart card redirection, so, I've done it through srv->scard_*... My point is, there are calls that I just couldn't adapt to the current API interface. Smart card redirection is not like an ordinary plugin... I'm working on your suggestions right now, trying to make scard fit in the current API, if possible. Any other tips are welcome :) Thanks, Eduardo ------------------------------------------------------------------------------ WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd _______________________________________________ Freerdp-devel mailing list Freerdp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freerdp-devel
