On Fri, 2006-12-29 at 21:23 +0100, Dirk Meyer wrote:
> + # For all other cases this needs to be calculated. Because
> + # kaa.popcorn may not know the real fullscreen resolution
> + # for same displays, simple settings for an aspect like
X isn't a problem here, because kaa.display has X11Display.get_size.
Looks like FrameBuffer also has a similar method. Shouldn't this
functionality be provided in kaa.display for all supported displays, and
then kaa.popcorn can know the display's resolution?
Then all we would need is a display/monitor aspect ratio property, and
can internally calculate the pixel aspect.
(There's a bit of a terminology conflict here. In my first paragraph
above, we should do s/display/screen/. kaa.display would provide the
screen size, from which we can derive the screen's aspect ratio. The
display [monitor or tv] aspect would need to be provided to us.)
> + # different aspect ratio than the screen itself). And
> + # since a config should work with different X-Server
> + # resolutions this has to be a player property.
Well I think either way we need a player property, whether it's to
specify the display aspect ratio (equivalent to -monitoraspect in
mplayer) which is all we'd need if kaa.display provides the screen size,
or if it's to specify the pixel aspect ratio, which is what you're
suggesting here.
> + # An easy way to calculate this is to use
> + # a1 = display_aspect[0] * fullscreen[1]
> + # a2 = display_aspect[1] * fullscreen[0]
> + # set_property('%s:%s' % (a1, a2)
> + # with display_aspect as physical monitor aspect and
> + # fullscreen the maximum pixels.
> + # So for a 16:9 TV and a 800x600 screen the
> + # pixel-aspect-ratio is 16 * 600 : 9 * 800.
This math looks right.
> + # Note: the value has to be a string with int values or
> + # gstreamer won't work.
Ok. :)
I mentioned this on IRC earlier but you missed it, so I'll repeat here:
we should avoid using software scaling in the filter chain if the
video's frame size is above a certain size. For example if we decide a
640x480 OSD is good, we'd upscale any video smaller than that to
640x480, but leave videos larger than at alone (except for expand of
course). Then we defer the rest of the work to hardware scaling.
I think this is especially important for HD content, which is already
CPU demanding enough, adding software scaling to the mix may be the
difference between being able to play it or not.
Jason.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel
