Jason Tackaberry wrote: > On Fri, 2006-12-29 at 21:23 +0100, Dirk Meyer wrote: >> + # For all other cases this needs to be calculated. Because >> + # kaa.popcorn may not know the real fullscreen resolution >> + # for same displays, simple settings for an aspect like > > X isn't a problem here, because kaa.display has X11Display.get_size. > Looks like FrameBuffer also has a similar method. Shouldn't this > functionality be provided in kaa.display for all supported displays, and > then kaa.popcorn can know the display's resolution?
Well, for fb Display == Window. But I guess it should be possible. Not sure about other displays. What happens if you play a movie on a buffercanvas. Is it possible to get the real display size? >> + # An easy way to calculate this is to use >> + # a1 = display_aspect[0] * fullscreen[1] >> + # a2 = display_aspect[1] * fullscreen[0] >> + # set_property('%s:%s' % (a1, a2) >> + # with display_aspect as physical monitor aspect and >> + # fullscreen the maximum pixels. >> + # So for a 16:9 TV and a 800x600 screen the >> + # pixel-aspect-ratio is 16 * 600 : 9 * 800. > > This math looks right. It is. I tried it with gstreamer which works exactly that way. So what should it be? Pixel-aspect-ratio or monitor-aspect? We could do both (more or less). We could set the default pixel-aspect-ratio based on the monitor aspect if provided in the config. > I mentioned this on IRC earlier but you missed it, so I'll repeat here: > we should avoid using software scaling in the filter chain if the > video's frame size is above a certain size. For example if we decide a > 640x480 OSD is good, we'd upscale any video smaller than that to > 640x480, but leave videos larger than at alone (except for expand of > course). Then we defer the rest of the work to hardware scaling. What about osd? If the sizes always change between freevo and the movies, we have to use per centage and not pixels in the gui. I plan to do this anyway, but it has to be that way in that case. BTW, what happens if you have a movie with 480x480 (SVCD, DVD has similar problems) and it is scaled based on the aspect? Should be also create an osd in 480x480 with the same aspect and let the hardware scaler correct it? What happens if the movie aspect changes (possible for DVD)? The pixel width and height are still the same, but the osd needs to be drawn differently. Dischi -- Don't piss me off - I'm running out of places to hide the bodies.
pgpnI033hy7Ew.pgp
Description: PGP signature
------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________ Freevo-devel mailing list Freevo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-devel