Hi Martin,
On Monday 27 November 2006 12:53, Martin Knoblauch wrote:
> >
> > I'd prefer to change this by patching the llist.h of Ganglia. Does
> > anybody have objections to this?
>
> Before fixing things either way, we should take a closer look. Could
> you show us the offending difference between the two versions? I made
> some changes over a year ago. Those were just cosmetic and did not
> change the order.
Ganglia has in lib/llist.h:
typedef struct _llist_entry {
void *val; /* Entry value */
struct _llist_entry *prev; /* Previous entry on list */
struct _llist_entry *next; /* Next entry on list */
} llist_entry;
while the original libe package llist.h is:
typedef struct _llist_entry {
struct _llist_entry *prev; /* Previous entry on list */
struct _llist_entry *next; /* Next entry on list */
void *val; /* Entry value */
} llist_entry;
When building the gexec RPM one uses libe-devel for llist.h, but links with
libganglia.a. Therefore "val" is broken when gexec is used with ganglia.
Obviously llist.h has been incorporated into ganglia long time ago and for
some (IMHO) unimportant reason the order of variables is reversed. I verified
that the patch (doing it the libe way inside ganglia) doesn't break
ganglia. Well, of course not. The only danger is for applications using
libganglia.a, those would need to be rebuilt.
> > Over the long term it would make sense to either build ganglia with
> > libe or
> > maybe even integrate libe into ganglia and produce the libe RPM when
> > building
> > ganglia. I saw that gexec is also integrated into the ganglia SVN
> > tree: is
> > this now the main development tree for gexec?
> >
>
> Integrating gexec/libe into standard ganglia builds sounds good to me.
> As for the "main development tree gexec" question - what development?
> Last changes have been over two years ago. And I think it has been
> broken since then.
Gexec can be found at http://www.theether.org/gexec/ (the site of the author,
Brent Chun) but also in the ganglia SVN tree at
https://svn.sourceforge.net/svnroot/ganglia/trunk/gexec
If there was some agreement to integrate gexec into ganglia or keep these
packages together, it would make sense to do it with libe and authd, too.
Best regards,
Erich
