Hi Erich,

--- Erich Focht <[EMAIL PROTECTED]> wrote:

> Hi Martin,
> 
> On Monday 27 November 2006 12:53, Martin Knoblauch wrote:
> > > 
> > > I'd prefer to change this by patching the llist.h of Ganglia.
> Does
> > > anybody have objections to this? 
> > 
> >  Before fixing things either way, we should take a closer look.
> Could
> > you show us the offending difference between the two versions? I
> made
> > some changes over a year ago. Those were just cosmetic and did not
> > change the order.
> 
> Ganglia has in lib/llist.h:
> 
> typedef struct _llist_entry {
>     void                    *val;   /* Entry value              */
>     struct _llist_entry     *prev;  /* Previous entry on list   */
>     struct _llist_entry     *next;  /* Next entry on list       */
> } llist_entry;
> 
> while the original libe package llist.h is:
> 
> typedef struct _llist_entry {
>     struct _llist_entry     *prev;  /* Previous entry on list   */
>     struct _llist_entry     *next;  /* Next entry on list       */
>     void                    *val;   /* Entry value              */
> } llist_entry;
> 
> 

 the "libe" version looks more textbook like. I think we should take it
:-)

Martin

------------------------------------------------------
Martin Knoblauch
email: k n o b i AT knobisoft DOT de
www:   http://www.knobisoft.de

Reply via email to