On Mon, 1 Dec 2025 at 19:52, Patrick Palka <[email protected]> wrote:
>
> On Wed, 26 Nov 2025, Yuao Ma wrote:
> > diff --git 
> > a/libstdc++-v3/testsuite/23_containers/flat_multiset/constexpr.cc 
> > b/libstdc++-v3/testsuite/23_containers/flat_multiset/constexpr.cc
> > new file mode 100644
> > index 00000000000..860b7660809
> > --- /dev/null
> > +++ b/libstdc++-v3/testsuite/23_containers/flat_multiset/constexpr.cc
> > @@ -0,0 +1,239 @@
> > +// { dg-do run { target c++26 } }
>
> I'd expect constexpr tests to be compile-only.

The tests have a main() function which calls VERIFY(test()), which
only has an effect at runtime.

Either they should be dg-do run, or the main() function can be removed
and just keep:

static_assert( test() );

Do these new tests add any checks which are not already covered by
existing runtime tests for flat_set and flat_multiset?

If they don't add anything new, then remove the main() function and
just do static_assert(test());

Reply via email to