> Eliminate the easy mistakes in patches. GCC uses strict coding conventions, > including formatting and commenting conventions, so not following them is a > mistake that will be flagged as such. Fortunately this is easy to correct, > you don't even need to read the (whole) documentation, just look around in > the existing code you're modifying and make it so that the new code cannot > be distinguished from the old one in this respect. > > Write proper ChangeLogs. They are kind of executive summaries for patches > and help to grasp what they do. The various ChangeLog files have many > examples.
Moreover, I think that having a patch that's improperly formatted or missing or improper ChangeLog may simply cause reviewers to ignore the patch because they don't want to have to deal with explaining these things to people. This SHOULDN'T happen, but I'm pretty sure it does.
