(Just saw Jonathan's email) That approach to `ids` makes sense to me. Let's try and get the current PR merged and I'll submit that as a followup PR (I have a few other minor changes I want to make too, but have been holding off since the current one is too enormous as-is)
On Tue, 11 Dec 2018 at 13:07 Craig de Stigter < [email protected]> wrote: > Thanks for the votes and kind words :) > > I'd applied Kurt's super-minor wording suggestions but haven't added any > new sections (on fiona, extra examples, etc) yet. I'll try and incorporate > those changes in the next couple days. > > Cheers > Craig > > On Tue, 11 Dec 2018 at 11:07 Kurt Schwehr <[email protected]> wrote: > >> To follow on to Howard's comment about testing in python... >> >> I'm looking forward to the day that GDAL can drop all python 2.x support >> and testing! >> >> And anyone working on C++ testing is welcome to the code here. I'll >> happily donate it with a license change to GDAL (it's apache 2.0 right >> now). You are free refactor however. Or just use any bits that you think >> are helpful if going to a different testing library. I can also donate >> some of the 80+k files in my fuzzer corpus as test inputs that cover weird >> corners of the code. >> >> https://github.com/schwehr/gdal-autotest2/tree/master/cpp >> >> On Mon, Dec 10, 2018 at 11:39 AM Howard Butler <[email protected]> wrote: >> >>> +1 >>> >>> I watched the ticket traffic and shuddered :) Thank you. GDAL's testing >>> probably predates five or six Python testing regimes/eras. I also have >>> the concern about GDAL's testing going through Python, but this RFC will >>> make it much easier for people to contribute and improve the story. >>> >>> >>> Congratulations on a huge lift! >>> >>> >>> Howard >>> >>> >>> On 12/9/18 9:48 PM, Kurt Schwehr wrote: >>> > I haven't had a chance to read the RFC yet, so I can't yet vote. >>> However, >>> > a huge thank you to Craig and everyone else who put in effort to make >>> this >>> > happen! >>> > >>> > On Sun, Dec 9, 2018 at 7:05 PM Craig de Stigter < >>> > [email protected]> wrote: >>> > >>> >> Jonathan >>> >> >>> >>> it's worth spending a little thought on coming up with a scheme for >>> >> test-ids. >>> >> >>> >> I've been through the list of parametrized tests and tweaked the `ids` >>> >> kwargs to make them a little more helpful at first glance: >>> >> >>> https://github.com/OSGeo/gdal/pull/963/commits/8db599e7bc08b7dc73d81591898ed0f5f4243a58 >>> >> >>> >> I didn't see any way to use `pytest_make_parametrize_id` really; IDs >>> >> rightly vary enough between tests that I can't see that hook being >>> very >>> >> useful here. >>> >> >>> >> Cheers >>> >> Craig de Stigter >>> >> >>> >> On Mon, 10 Dec 2018 at 09:59 jratike80 < >>> >> [email protected]> wrote: >>> >> >>> >>> +0 >>> >>> >>> >>> -Jukka Rahkonen- >>> >>> >>> >>> >>> >>> Even Rouault-2 wrote >>> >>>> PSC members, >>> >>>> >>> >>>> gentle reminder to cast your vote on this. >>> >>>> >>> >>>> Thanks, >>> >>>> >>> >>>> Even >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> -- >>> >>> Sent from: >>> http://osgeo-org.1560.x6.nabble.com/GDAL-Dev-f3742093.html >>> >>> _______________________________________________ >>> >>> gdal-dev mailing list >>> >>> [email protected] >>> >>> https://lists.osgeo.org/mailman/listinfo/gdal-dev >>> >> _______________________________________________ >>> >> gdal-dev mailing list >>> >> [email protected] >>> >> https://lists.osgeo.org/mailman/listinfo/gdal-dev >>> > >>> > >>> > >>> > _______________________________________________ >>> > gdal-dev mailing list >>> > [email protected] >>> > https://lists.osgeo.org/mailman/listinfo/gdal-dev >>> >>> _______________________________________________ >>> gdal-dev mailing list >>> [email protected] >>> https://lists.osgeo.org/mailman/listinfo/gdal-dev >> >> >> >> -- >> -- >> http://schwehr.org >> _______________________________________________ >> gdal-dev mailing list >> [email protected] >> https://lists.osgeo.org/mailman/listinfo/gdal-dev > >
_______________________________________________ gdal-dev mailing list [email protected] https://lists.osgeo.org/mailman/listinfo/gdal-dev
