Deepak, some general comments ...

- Gears doesn't use default values for parameters, so we should either
use a separate method for the case where the BrowsingContext is
supplied, or pass NULL for PIE.
- I think that at least for CabUpdater (the outward-facing API for
this set of classes), we should use a separate Constructor for Opera
which takes the BrowsingContext parameter, rather than modifying the
current constructor. We can then ifdef this on Opera and add a comment
to make it clear that the need for the BrowsingContext is not
fundamental and is only an implementation detail of the Opera
HttpRequest. Andrei, what do you think?
- On Opera, the Cabupdater will be started only when the user first
visits a Gears-enabled page, right? Apologies if you've already
answered this, but what happens if the user navigates away from that
page, thus invalidating the BrowsingContext, before the CabUpdater has
finished using it?
- We should define a constant for the case where "gearsop" is used
multiple times in a file.

Steve

Reply via email to