You must have forgotten to upload the latest snapshot? ======================================================================== http://mondrian.corp.google.com/file/9877173///depot/googleclient/gears/opensource/gears/installer/common/cab_updater.cc?a=1 File //depot/googleclient/gears/opensource/gears/installer/common/cab_updater.cc (snapshot 1) ------------------------------------ Line 44: const int32 kFirstUpdatePeriod = (1000 * 2); // 2 seconds maybe add a comment explaining why only 2 secs on opera. ------------------------------------ Line 56: browsing_context_(browsing_context), tab ------------------------------------ Line 195: DownloadTask::Create(url.c_str(), temp_file_path_.c_str(), this, browsing_context_.get()); line too long ======================================================================== http://mondrian.corp.google.com/file/9877173///depot/googleclient/gears/opensource/gears/installer/common/cab_updater.h?a=1 File //depot/googleclient/gears/opensource/gears/installer/common/cab_updater.h (snapshot 1) ------------------------------------ Line 52: CabUpdater(BrowsingContext *browsing_context = NULL); I thought default params are not allowed in google code? ======================================================================== http://mondrian.corp.google.com/file/9877173///depot/googleclient/gears/opensource/gears/installer/common/download_task.cc?a=1 File //depot/googleclient/gears/opensource/gears/installer/common/download_task.cc (snapshot 1) ------------------------------------ Line 38: BrowsingContext *browsing_context) { tabs ------------------------------------ Line 39: scoped_ptr<DownloadTask> task(new DownloadTask(url, save_path, listener, browsing_context)); line too long ------------------------------------ Line 55: BrowsingContext *browsing_context) tabs ======================================================================== http://mondrian.corp.google.com/file/9877173///depot/googleclient/gears/opensource/gears/installer/common/download_task.h?a=1 File //depot/googleclient/gears/opensource/gears/installer/common/download_task.h (snapshot 1) ------------------------------------ Line 47: BrowsingContext *browsing_context = NULL); tabs, default params ------------------------------------ Line 55: BrowsingContext *browsing_context = NULL); tabs, default param ======================================================================== http://mondrian.corp.google.com/file/9877173///depot/googleclient/gears/opensource/gears/installer/common/periodic_checker.cc?a=1 File //depot/googleclient/gears/opensource/gears/installer/common/periodic_checker.cc (snapshot 1) ------------------------------------ Line 36: #include "gears/base/common/browsing_context.h" wrong include order ------------------------------------ Line 79: BrowsingContext *browsing_context = NULL); tabs ------------------------------------ Line 91: VersionFetchTask(const std::string16 &guid, HWND listener_window, BrowsingContext *browsing_context = NULL); line too long, default param ------------------------------------ Line 114: PeriodicChecker* PeriodicChecker::CreateChecker(BrowsingContext *browsing_context) { line too long ------------------------------------ Line 115: return new PeriodicChecker(browsing_context); tab ------------------------------------ Line 143: browsing_context_(browsing_context), tab ------------------------------------ Line 309: BrowsingContext *browsing_context) { tabs ------------------------------------ Line 327: BrowsingContext* browsing_context) tabs ======================================================================== http://mondrian.corp.google.com/file/9877173///depot/googleclient/gears/opensource/gears/installer/common/periodic_checker.h?a=1 File //depot/googleclient/gears/opensource/gears/installer/common/periodic_checker.h (snapshot 1) ------------------------------------ Line 39: #include "gears/base/common/browsing_context.h" wrong include order ------------------------------------ Line 52: static PeriodicChecker* CreateChecker(BrowsingContext *browsing_context = NULL); line too long, default param ------------------------------------ Line 80: PeriodicChecker(BrowsingContext *browsing_context = NULL); default param ========================================================================
-- To respond, reply to this email or visit http://mondrian.corp.google.com/9877173
