Adding Deepak and Stig back on the thread. ---------- Forwarded message ---------- From: Andrei Popescu <[email protected]> Date: Thu, Jan 29, 2009 at 12:14 PM Subject: Re: a medium-size code review (9877173) Modifies CabUpdater to pass a BrowsingContex To: Steve Block <[email protected]> Cc: Deepak Patil <[email protected]>, [email protected], [email protected], [email protected], [email protected]
For the default param problem, how about this: - Have an Opera-specific CabUpdaterOpera class that derives from the common CabUpdater. - Have the installer implementation classes (VersionFetchTask, PeriodicChecker) take a BrowsingContext pointer. On IEMobile we just pass NULL. ======================================================================== http://mondrian.corp.google.com/file/9877173///depot/googleclient/gears/opensource/gears/installer/common/periodic_checker.h?a=1 File //depot/googleclient/gears/opensource/gears/installer/common/periodic_checker.h (snapshot 1) ------------------------------------ Line 34: #define GEARS_INSTALLER_IEMOBILE_PERIODIC_CHECKER_H__ Wrong header guard ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/9877173
