jonnybot0 commented on code in PR #277:
URL: https://github.com/apache/groovy-geb/pull/277#discussion_r2164696277
##########
doc/manual/src/docs/asciidoc/120-build-integrations.adoc:
##########
@@ -10,37 +10,88 @@ Using Geb with Gradle simply involves pulling in the
appropriate dependencies, a
Below is a valid Gradle `build.gradle` file for working with Geb for testing.
-[source,groovy,subs="attributes"]
+[tabs]
+====
+Kotlin::
++
+[source,kotlin,subs="+attributes"]
----
-apply plugin: "groovy"
+plugins {
+ groovy
+}
repositories {
mavenCentral()
}
-ext {
- gebVersion = "{geb-version}"
- seleniumVersion = "{selenium-version}"
-}
+val gebVersion = "{geb-version}"
+val seleniumVersion = "{selenium-version}"
+
+testing {
Review Comment:
Why this switch to using the `testing` block? That doesn't seem to be the
"out of the box" way that Gradle documents setting up the testing block for
Java projects. See https://docs.gradle.org/current/userguide/java_testing.html.
Is there some compelling reason for this? It seems like the old approach was
a bit simpler and more standard. Of course, the "right" way to do Gradle is
always a moving target, so I may just be behind the times. Feel free to school
me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
