jonnybot0 commented on code in PR #277:
URL: https://github.com/apache/groovy-geb/pull/277#discussion_r2164754194
##########
settings.gradle:
##########
@@ -23,6 +23,12 @@ plugins {
// updating this, check the compatibility from
https://docs.gradle.com/enterprise/compatibility/#develocity_compatibility and
https://develocity.apache.org/scans.
id "com.gradle.develocity" version "3.18.2"
id 'com.gradle.common-custom-user-data-gradle-plugin' version '2.0.2'
+ // The Ratpack server providing the gem repository uses classes from
+ // jakarta.activation-api.jar brought in here by
org.kordamp.gradle.oci-build-cache
+ // but the classes in there cannot work properly as classes from
+ // the activation implementation are missing, so bring the plugin
+ // to the classpath here to fix compatibility problems
+ id 'org.asciidoctor.jvm.gems' version '4.0.4' apply false
Review Comment:
What do I need to do in order to reproduce the error you are describing
here? If I take this out and put the 4.0.4 version ref in libs.versions.toml,
the doc site still seems to build okay for me locally using Java 17 and
`./gradlew doc:manual:build`.
##########
doc/manual/src/docs/asciidoc/060-configuration.adoc:
##########
@@ -28,25 +28,39 @@ using the class loader that loaded Geb.
[NOTE]
====
-If you are using a build tool such as link:http://gradle.org/[Gradle] or
link:http://maven.apache.org/[Maven] that has the concept of test “resources”,
then that directory is a suitable place.
+If you are using a build tool such as link:https://gradle.org/[Gradle] or
link:https://maven.apache.org/[Maven] that has the concept of test
"`resources`", then that directory is a suitable place.
You can also put your script together with your compilation source and then
the compiled version of the script will be used.
====
==== Environment sensitivity
The Groovy `{config-slurper-api}` mechanism has built in support for
environment sensitive configuration, and Geb leverages this by using the
*`geb.env`* system property to determine the environment
to use.
-An effective use of this mechanism is to configure different drivers based on
the designated Geb “environment” (concrete details on how to do this further
down).
+An effective use of this mechanism is to configure different drivers based on
the designated Geb "`environment`" (concrete details on how to do this further
down).
How you set the environment system property is going to be dependent on the
build system you are using.
-For example, when using Gradle you could control the Geb environment by
specifying it in the configuration of the test task running your tests…
+For example, when using Gradle you could control the Geb environment by
specifying it in the configuration of the test task running your tests...
+[tabs]
Review Comment:
I like the use of these tabs here. Looks much more like the Gradle website,
which I think will be good for readers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
